APEX/BrowserUse_and_ComputerUse_skills
5
0
Fork 0
Code Issues 6 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

fix(state): add missing thread lock to session_count() and message_count()

Browse source 
Both methods accessed self._conn without self._lock, breaking the
thread-safety contract documented on SessionDB (line 111). All 22 other
DB methods use with self._lock — these two were the only exceptions.

In the gateway's multi-threaded environment (multiple platform reader
threads + single writer) this could cause cursor interleaving,
sqlite3.ProgrammingError, or inconsistent COUNT results.

Closes #2130
This commit is contained in:
Hermes 2026-03-21 10:15:06 +00:00 • committed by Teknium
parent f3301a31d5
commit 2de42ba690
No known key found for this signature in database
1 changed files with 16 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

2
hermes_state.py
View file

@ -855,6 +855,7 @@ class SessionDB:
def session_count(self, source: str = None) -> int: def session_count(self, source: str = None) -> int:
"""Count sessions, optionally filtered by source.""" """Count sessions, optionally filtered by source."""
with self._lock:
if source: if source:
cursor = self._conn.execute( cursor = self._conn.execute(
"SELECT COUNT(*) FROM sessions WHERE source = ?", (source,) "SELECT COUNT(*) FROM sessions WHERE source = ?", (source,)
@ -865,6 +866,7 @@ class SessionDB:
def message_count(self, session_id: str = None) -> int: def message_count(self, session_id: str = None) -> int:
"""Count messages, optionally for a specific session.""" """Count messages, optionally for a specific session."""
with self._lock:
if session_id: if session_id:
cursor = self._conn.execute( cursor = self._conn.execute(
"SELECT COUNT(*) FROM messages WHERE session_id = ?", (session_id,) "SELECT COUNT(*) FROM messages WHERE session_id = ?", (session_id,)