APEX/BrowserUse_and_ComputerUse_skills
5
0
Fork 0
Code Issues 6 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

fix: add macOS Homebrew Opus fallback and fix shutdown dict iteration

Browse source 
- Add Homebrew library path fallback when ctypes.util.find_library fails
  on macOS (Apple Silicon + Intel paths, guarded by platform check)
- Fix RuntimeError in gateway stop() by iterating over dict copy
- Update Opus tests to verify find_library-first + conditional fallback
This commit is contained in:
0xbyt4 2026-03-13 16:59:03 +03:00
parent c797314fcf
commit 44abe852fb
3 changed files with 33 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

29
tests/gateway/test_discord_opus.py
View file

@ -4,22 +4,31 @@ import inspect
class TestOpusFindLibrary:
"""Opus loading must use ctypes.util.find_library, not hardcoded paths."""
"""Opus loading must try ctypes.util.find_library first, with platform fallback."""
def test_no_hardcoded_opus_path(self):
from gateway.platforms.discord import DiscordAdapter
source = inspect.getsource(DiscordAdapter.connect)
assert "/opt/homebrew" not in source, \
"Opus loading must not use hardcoded /opt/homebrew path"
assert "libopus.so.0" not in source, \
"Opus loading must not use hardcoded libopus.so.0 path"
def test_uses_find_library(self):
def test_uses_find_library_first(self):
"""find_library must be the primary lookup strategy."""
from gateway.platforms.discord import DiscordAdapter
source = inspect.getsource(DiscordAdapter.connect)
assert "find_library" in source, \
"Opus loading must use ctypes.util.find_library"
def test_homebrew_fallback_is_conditional(self):
"""Homebrew paths must only be tried when find_library returns None."""
from gateway.platforms.discord import DiscordAdapter
source = inspect.getsource(DiscordAdapter.connect)
# Homebrew fallback must exist
assert "/opt/homebrew" in source or "homebrew" in source, \
"Opus loading should have macOS Homebrew fallback"
# find_library must appear BEFORE any Homebrew path
fl_idx = source.index("find_library")
hb_idx = source.index("/opt/homebrew")
assert fl_idx < hb_idx, \
"find_library must be tried before Homebrew fallback paths"
# Fallback must be guarded by platform check
assert "sys.platform" in source or "darwin" in source, \
"Homebrew fallback must be guarded by macOS platform check"
def test_opus_decode_error_logged(self):
"""Opus decode failure must log the error, not silently return."""
from gateway.platforms.discord import VoiceReceiver