The architecture has been updated
This commit is contained in:
parent
805f7a017e
commit
a01257ead9
1119 changed files with 226 additions and 352 deletions
|
|
@ -1,284 +0,0 @@
|
|||
"""Tests for the central tool registry."""
|
||||
|
||||
import json
|
||||
|
||||
from tools.registry import ToolRegistry
|
||||
|
||||
|
||||
def _dummy_handler(args, **kwargs):
|
||||
return json.dumps({"ok": True})
|
||||
|
||||
|
||||
def _make_schema(name="test_tool"):
|
||||
return {
|
||||
"name": name,
|
||||
"description": f"A {name}",
|
||||
"parameters": {"type": "object", "properties": {}},
|
||||
}
|
||||
|
||||
|
||||
class TestRegisterAndDispatch:
|
||||
def test_register_and_dispatch(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="alpha",
|
||||
toolset="core",
|
||||
schema=_make_schema("alpha"),
|
||||
handler=_dummy_handler,
|
||||
)
|
||||
result = json.loads(reg.dispatch("alpha", {}))
|
||||
assert result == {"ok": True}
|
||||
|
||||
def test_dispatch_passes_args(self):
|
||||
reg = ToolRegistry()
|
||||
|
||||
def echo_handler(args, **kw):
|
||||
return json.dumps(args)
|
||||
|
||||
reg.register(
|
||||
name="echo",
|
||||
toolset="core",
|
||||
schema=_make_schema("echo"),
|
||||
handler=echo_handler,
|
||||
)
|
||||
result = json.loads(reg.dispatch("echo", {"msg": "hi"}))
|
||||
assert result == {"msg": "hi"}
|
||||
|
||||
|
||||
class TestGetDefinitions:
|
||||
def test_returns_openai_format(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="t1", toolset="s1", schema=_make_schema("t1"), handler=_dummy_handler
|
||||
)
|
||||
reg.register(
|
||||
name="t2", toolset="s1", schema=_make_schema("t2"), handler=_dummy_handler
|
||||
)
|
||||
|
||||
defs = reg.get_definitions({"t1", "t2"})
|
||||
assert len(defs) == 2
|
||||
assert all(d["type"] == "function" for d in defs)
|
||||
names = {d["function"]["name"] for d in defs}
|
||||
assert names == {"t1", "t2"}
|
||||
|
||||
def test_skips_unavailable_tools(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="available",
|
||||
toolset="s",
|
||||
schema=_make_schema("available"),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: True,
|
||||
)
|
||||
reg.register(
|
||||
name="unavailable",
|
||||
toolset="s",
|
||||
schema=_make_schema("unavailable"),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: False,
|
||||
)
|
||||
defs = reg.get_definitions({"available", "unavailable"})
|
||||
assert len(defs) == 1
|
||||
assert defs[0]["function"]["name"] == "available"
|
||||
|
||||
|
||||
class TestUnknownToolDispatch:
|
||||
def test_returns_error_json(self):
|
||||
reg = ToolRegistry()
|
||||
result = json.loads(reg.dispatch("nonexistent", {}))
|
||||
assert "error" in result
|
||||
assert "Unknown tool" in result["error"]
|
||||
|
||||
|
||||
class TestToolsetAvailability:
|
||||
def test_no_check_fn_is_available(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="t", toolset="free", schema=_make_schema(), handler=_dummy_handler
|
||||
)
|
||||
assert reg.is_toolset_available("free") is True
|
||||
|
||||
def test_check_fn_controls_availability(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="t",
|
||||
toolset="locked",
|
||||
schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: False,
|
||||
)
|
||||
assert reg.is_toolset_available("locked") is False
|
||||
|
||||
def test_check_toolset_requirements(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="a",
|
||||
toolset="ok",
|
||||
schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: True,
|
||||
)
|
||||
reg.register(
|
||||
name="b",
|
||||
toolset="nope",
|
||||
schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: False,
|
||||
)
|
||||
|
||||
reqs = reg.check_toolset_requirements()
|
||||
assert reqs["ok"] is True
|
||||
assert reqs["nope"] is False
|
||||
|
||||
def test_get_all_tool_names(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="z_tool", toolset="s", schema=_make_schema(), handler=_dummy_handler
|
||||
)
|
||||
reg.register(
|
||||
name="a_tool", toolset="s", schema=_make_schema(), handler=_dummy_handler
|
||||
)
|
||||
assert reg.get_all_tool_names() == ["a_tool", "z_tool"]
|
||||
|
||||
def test_handler_exception_returns_error(self):
|
||||
reg = ToolRegistry()
|
||||
|
||||
def bad_handler(args, **kw):
|
||||
raise RuntimeError("boom")
|
||||
|
||||
reg.register(
|
||||
name="bad", toolset="s", schema=_make_schema(), handler=bad_handler
|
||||
)
|
||||
result = json.loads(reg.dispatch("bad", {}))
|
||||
assert "error" in result
|
||||
assert "RuntimeError" in result["error"]
|
||||
|
||||
|
||||
class TestCheckFnExceptionHandling:
|
||||
"""Verify that a raising check_fn is caught rather than crashing."""
|
||||
|
||||
def test_is_toolset_available_catches_exception(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="t",
|
||||
toolset="broken",
|
||||
schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: 1 / 0, # ZeroDivisionError
|
||||
)
|
||||
# Should return False, not raise
|
||||
assert reg.is_toolset_available("broken") is False
|
||||
|
||||
def test_check_toolset_requirements_survives_raising_check(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="a",
|
||||
toolset="good",
|
||||
schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: True,
|
||||
)
|
||||
reg.register(
|
||||
name="b",
|
||||
toolset="bad",
|
||||
schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: (_ for _ in ()).throw(ImportError("no module")),
|
||||
)
|
||||
|
||||
reqs = reg.check_toolset_requirements()
|
||||
assert reqs["good"] is True
|
||||
assert reqs["bad"] is False
|
||||
|
||||
def test_get_definitions_skips_raising_check(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="ok_tool",
|
||||
toolset="s",
|
||||
schema=_make_schema("ok_tool"),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: True,
|
||||
)
|
||||
reg.register(
|
||||
name="bad_tool",
|
||||
toolset="s2",
|
||||
schema=_make_schema("bad_tool"),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: (_ for _ in ()).throw(OSError("network down")),
|
||||
)
|
||||
defs = reg.get_definitions({"ok_tool", "bad_tool"})
|
||||
assert len(defs) == 1
|
||||
assert defs[0]["function"]["name"] == "ok_tool"
|
||||
|
||||
def test_check_tool_availability_survives_raising_check(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="a",
|
||||
toolset="works",
|
||||
schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: True,
|
||||
)
|
||||
reg.register(
|
||||
name="b",
|
||||
toolset="crashes",
|
||||
schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
check_fn=lambda: 1 / 0,
|
||||
)
|
||||
|
||||
available, unavailable = reg.check_tool_availability()
|
||||
assert "works" in available
|
||||
assert any(u["name"] == "crashes" for u in unavailable)
|
||||
|
||||
|
||||
class TestEmojiMetadata:
|
||||
"""Verify per-tool emoji registration and lookup."""
|
||||
|
||||
def test_emoji_stored_on_entry(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="t", toolset="s", schema=_make_schema(),
|
||||
handler=_dummy_handler, emoji="🔥",
|
||||
)
|
||||
assert reg._tools["t"].emoji == "🔥"
|
||||
|
||||
def test_get_emoji_returns_registered(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="t", toolset="s", schema=_make_schema(),
|
||||
handler=_dummy_handler, emoji="🎯",
|
||||
)
|
||||
assert reg.get_emoji("t") == "🎯"
|
||||
|
||||
def test_get_emoji_returns_default_when_unset(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="t", toolset="s", schema=_make_schema(),
|
||||
handler=_dummy_handler,
|
||||
)
|
||||
assert reg.get_emoji("t") == "⚡"
|
||||
assert reg.get_emoji("t", default="🔧") == "🔧"
|
||||
|
||||
def test_get_emoji_returns_default_for_unknown_tool(self):
|
||||
reg = ToolRegistry()
|
||||
assert reg.get_emoji("nonexistent") == "⚡"
|
||||
assert reg.get_emoji("nonexistent", default="❓") == "❓"
|
||||
|
||||
def test_emoji_empty_string_treated_as_unset(self):
|
||||
reg = ToolRegistry()
|
||||
reg.register(
|
||||
name="t", toolset="s", schema=_make_schema(),
|
||||
handler=_dummy_handler, emoji="",
|
||||
)
|
||||
assert reg.get_emoji("t") == "⚡"
|
||||
|
||||
|
||||
class TestSecretCaptureResultContract:
|
||||
def test_secret_request_result_does_not_include_secret_value(self):
|
||||
result = {
|
||||
"success": True,
|
||||
"stored_as": "TENOR_API_KEY",
|
||||
"validated": False,
|
||||
}
|
||||
assert "secret" not in json.dumps(result).lower()
|
||||
Loading…
Add table
Add a link
Reference in a new issue