APEX/BrowserUse_and_ComputerUse_skills
5
0
Fork 0
Code Issues 6 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

fix: ignore placeholder provider keys in provider activation checks

Browse source 
Add has_usable_secret() to reject empty, short (<4 char), and common
placeholder API key values (changeme, your_api_key, placeholder, etc.)
throughout the auth/runtime resolution chain.

Update list_available_providers() to use provider-specific auth status
via get_auth_status() instead of resolve_runtime_provider(), preventing
cross-provider key fallback from making providers appear available when
they aren't actually configured.

Preserve keyless custom endpoint support by checking via base URL.

Cherry-picked from PR #2121 by aashizpoudel.
This commit is contained in:
aashizpoudel 2026-03-21 12:55:42 -07:00 • committed by Teknium
parent b73d221324
commit f304bc63b8
No known key found for this signature in database
3 changed files with 60 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

33
hermes_cli/auth.py
View file

@ -278,6 +278,33 @@ def _try_gh_cli_token() -> Optional[str]:
return None
_PLACEHOLDER_SECRET_VALUES = {
"*",
"**",
"***",
"changeme",
"your_api_key",
"your-api-key",
"placeholder",
"example",
"dummy",
"null",
"none",
}
def has_usable_secret(value: Any, *, min_length: int = 4) -> bool:
"""Return True when a configured secret looks usable, not empty/placeholder."""
if not isinstance(value, str):
return False
cleaned = value.strip()
if len(cleaned) < min_length:
return False
if cleaned.lower() in _PLACEHOLDER_SECRET_VALUES:
return False
return True
def _resolve_api_key_provider_secret(
provider_id: str, pconfig: ProviderConfig
) -> tuple[str, str]:
@ -297,7 +324,7 @@ def _resolve_api_key_provider_secret(
for env_var in pconfig.api_key_env_vars:
val = os.getenv(env_var, "").strip()
if val:
if has_usable_secret(val):
return val, env_var
return "", ""
@ -688,7 +715,7 @@ def resolve_provider(
except Exception as e:
logger.debug("Could not detect active auth provider: %s", e)
if os.getenv("OPENAI_API_KEY") or os.getenv("OPENROUTER_API_KEY"):
if has_usable_secret(os.getenv("OPENAI_API_KEY")) or has_usable_secret(os.getenv("OPENROUTER_API_KEY")):
return "openrouter"
# Auto-detect API-key providers by checking their env vars
@ -701,7 +728,7 @@ def resolve_provider(
if pid == "copilot":
continue
for env_var in pconfig.api_key_env_vars:
if os.getenv(env_var, "").strip():
if has_usable_secret(os.getenv(env_var, "")):
return pid
return "openrouter"