APEX/BrowserUse_and_ComputerUse_skills
5
0
Fork 0
Code Issues 6 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

fix(honcho): hide session banner when not explicitly configured

Browse source 
Add explicitly_configured field to HonchoClientConfig — set when the
config has a hosts.hermes block or explicit enabled flag, vs auto-enabled
from a stray HONCHO_API_KEY env var.  Banner only shows when this is true.

Based on #1960 by @erosika, reimplemented without duplicating config parsing.
This commit is contained in:
Teknium 2026-03-21 08:33:44 -07:00
parent 488a30e879
commit f4a74d3ac7
No known key found for this signature in database
2 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
cli.py
View file

@ -165,10 +165,10 @@ def load_cli_config() -> Dict[str, Any]:
"cwd": ".", # "." is resolved to os.getcwd() at runtime "cwd": ".", # "." is resolved to os.getcwd() at runtime
"timeout": 60, "timeout": 60,
"lifetime_seconds": 300, "lifetime_seconds": 300,
"docker_image": "python:3.11", "docker_image": "nikolaik/python-nodejs:python3.11-nodejs20",
"docker_forward_env": [], "docker_forward_env": [],
"singularity_image": "docker://python:3.11", "singularity_image": "docker://nikolaik/python-nodejs:python3.11-nodejs20",
"modal_image": "python:3.11", "modal_image": "nikolaik/python-nodejs:python3.11-nodejs20",
"daytona_image": "nikolaik/python-nodejs:python3.11-nodejs20", "daytona_image": "nikolaik/python-nodejs:python3.11-nodejs20",
"docker_volumes": [], # host:container volume mounts for Docker backend "docker_volumes": [], # host:container volume mounts for Docker backend
"docker_mount_cwd_to_workspace": False, # explicit opt-in only; default off for sandbox isolation "docker_mount_cwd_to_workspace": False, # explicit opt-in only; default off for sandbox isolation
@ -5751,12 +5751,14 @@ class HermesCLI:
"""Run the interactive CLI loop with persistent input at bottom.""" """Run the interactive CLI loop with persistent input at bottom."""
self.show_banner() self.show_banner()
# One-line Honcho session indicator (TTY-only, not captured by agent) # One-line Honcho session indicator (TTY-only, not captured by agent).
# Only show when the user explicitly configured Honcho for Hermes
# (not auto-enabled from a stray HONCHO_API_KEY env var).
try: try:
from honcho_integration.client import HonchoClientConfig from honcho_integration.client import HonchoClientConfig
from agent.display import honcho_session_line, write_tty from agent.display import honcho_session_line, write_tty
hcfg = HonchoClientConfig.from_global_config() hcfg = HonchoClientConfig.from_global_config()
if hcfg.enabled and hcfg.api_key: if hcfg.enabled and hcfg.api_key and hcfg.explicitly_configured:
sname = hcfg.resolve_session_name(session_id=self.session_id) sname = hcfg.resolve_session_name(session_id=self.session_id)
if sname: if sname:
write_tty(honcho_session_line(hcfg.workspace_id, sname) + "\n") write_tty(honcho_session_line(hcfg.workspace_id, sname) + "\n")

8
honcho_integration/client.py
View file

@ -112,6 +112,10 @@ class HonchoClientConfig:
sessions: dict[str, str] = field(default_factory=dict) sessions: dict[str, str] = field(default_factory=dict)
# Raw global config for anything else consumers need # Raw global config for anything else consumers need
raw: dict[str, Any] = field(default_factory=dict) raw: dict[str, Any] = field(default_factory=dict)
# True when Honcho was explicitly configured for this host (hosts.hermes
# block exists or enabled was set explicitly), vs auto-enabled from a
# stray HONCHO_API_KEY env var.
explicitly_configured: bool = False
@classmethod @classmethod
def from_env(cls, workspace_id: str = "hermes") -> HonchoClientConfig: def from_env(cls, workspace_id: str = "hermes") -> HonchoClientConfig:
@ -148,6 +152,9 @@ class HonchoClientConfig:
return cls.from_env() return cls.from_env()
host_block = (raw.get("hosts") or {}).get(host, {}) host_block = (raw.get("hosts") or {}).get(host, {})
# A hosts.hermes block or explicit enabled flag means the user
# intentionally configured Honcho for this host.
_explicitly_configured = bool(host_block) or raw.get("enabled") is True
# Explicit host block fields win, then flat/global, then defaults # Explicit host block fields win, then flat/global, then defaults
workspace = ( workspace = (
@ -253,6 +260,7 @@ class HonchoClientConfig:
session_peer_prefix=session_peer_prefix, session_peer_prefix=session_peer_prefix,
sessions=raw.get("sessions", {}), sessions=raw.get("sessions", {}),
raw=raw, raw=raw,
explicitly_configured=_explicitly_configured,
) )
@staticmethod @staticmethod