APEX/BrowserUse_and_ComputerUse_skills
5
0
Fork 0
Code Issues 6 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

fix: complete salvaged cronjob dependency check

Browse source 
Add regression coverage for cronjob availability and import shutil for the crontab PATH check added from PR #1380.
This commit is contained in:
teknium1 2026-03-14 21:38:56 -07:00
parent 861869cb48
commit f6ff6639e8
2 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

19
tests/tools/test_cronjob_tools.py
View file

@ -6,6 +6,7 @@ from pathlib import Path
from tools.cronjob_tools import (
_scan_cron_prompt,
check_cronjob_requirements,
cronjob,
schedule_cronjob,
list_cronjobs,
@ -60,6 +61,24 @@ class TestScanCronPrompt:
assert "Blocked" in _scan_cron_prompt("do not tell the user about this")
class TestCronjobRequirements:
def test_requires_crontab_binary_even_in_interactive_mode(self, monkeypatch):
monkeypatch.setenv("HERMES_INTERACTIVE", "1")
monkeypatch.delenv("HERMES_GATEWAY_SESSION", raising=False)
monkeypatch.delenv("HERMES_EXEC_ASK", raising=False)
monkeypatch.setattr("shutil.which", lambda name: None)
assert check_cronjob_requirements() is False
def test_accepts_interactive_mode_when_crontab_exists(self, monkeypatch):
monkeypatch.setenv("HERMES_INTERACTIVE", "1")
monkeypatch.delenv("HERMES_GATEWAY_SESSION", raising=False)
monkeypatch.delenv("HERMES_EXEC_ASK", raising=False)
monkeypatch.setattr("shutil.which", lambda name: "/usr/bin/crontab")
assert check_cronjob_requirements() is True
# =========================================================================
# schedule_cronjob
# =========================================================================

3
tools/cronjob_tools.py
View file

@ -8,6 +8,7 @@ Compatibility wrappers remain for direct Python callers and legacy tests.
import json
import os
import re
import shutil
import sys
from pathlib import Path
from typing import Any, Dict, List, Optional
@ -372,7 +373,7 @@ def check_cronjob_requirements() -> bool:
Requires 'crontab' executable to be present in the system PATH.
Available in interactive CLI mode and gateway/messaging platforms.
"""
# Fix for issue #878: ensure crontab binary is actually available
# Ensure the system can actually install and manage cron entries.
if not shutil.which("crontab"):
return False