e629e34c4d
Normalize chat ids to a single UUID form so locks, repository keys, and mount paths cannot diverge through path-like aliases.
437 lines
13 KiB
Python
437 lines
13 KiB
Python
import asyncio
|
|
import json
|
|
from datetime import UTC, datetime, timedelta
|
|
|
|
from docker import DockerClient
|
|
from fastapi import FastAPI
|
|
from starlette.types import Message, Scope
|
|
|
|
from adapter.config.model import (
|
|
AppConfig,
|
|
AppSectionConfig,
|
|
DockerConfig,
|
|
HttpConfig,
|
|
LoggingConfig,
|
|
MetricsConfig,
|
|
OtelConfig,
|
|
SandboxConfig,
|
|
SecurityConfig,
|
|
TracingConfig,
|
|
)
|
|
from adapter.di.container import AppContainer, AppRepositories, AppUsecases
|
|
from adapter.http.fastapi import app as app_module
|
|
from adapter.observability.noop import NoopMetrics, NoopTracer
|
|
from adapter.observability.runtime import ObservabilityRuntime
|
|
from domain.error import SandboxError, SandboxStartError
|
|
from domain.sandbox import SandboxSession, SandboxStatus
|
|
from repository.sandbox_session import InMemorySandboxSessionRepository
|
|
from usecase.interface import Attrs
|
|
from usecase.sandbox import CleanupExpiredSandboxes, CreateSandbox, CreateSandboxCommand
|
|
|
|
CHAT_ID = '123e4567-e89b-12d3-a456-426614174000'
|
|
NON_CANONICAL_CHAT_ID = '123E4567E89B12D3A456426614174000'
|
|
|
|
|
|
class FakeLogger:
|
|
def __init__(self) -> None:
|
|
self.messages: list[tuple[str, str, Attrs | None]] = []
|
|
|
|
def debug(self, message: str, attrs: Attrs | None = None) -> None:
|
|
self.messages.append(('debug', message, attrs))
|
|
|
|
def info(self, message: str, attrs: Attrs | None = None) -> None:
|
|
self.messages.append(('info', message, attrs))
|
|
|
|
def warning(self, message: str, attrs: Attrs | None = None) -> None:
|
|
self.messages.append(('warning', message, attrs))
|
|
|
|
def error(self, message: str, attrs: Attrs | None = None) -> None:
|
|
self.messages.append(('error', message, attrs))
|
|
|
|
|
|
class FakeCreateSandboxUsecase(CreateSandbox):
|
|
def __init__(
|
|
self, session: SandboxSession | None = None, error: Exception | None = None
|
|
) -> None:
|
|
self._session = session
|
|
self._error = error
|
|
self.commands: list[CreateSandboxCommand] = []
|
|
|
|
def execute(self, command: CreateSandboxCommand) -> SandboxSession:
|
|
self.commands.append(command)
|
|
if self._error is not None:
|
|
raise self._error
|
|
if self._session is None:
|
|
raise AssertionError('missing session')
|
|
return self._session
|
|
|
|
|
|
class FakeCleanupExpiredSandboxes(CleanupExpiredSandboxes):
|
|
def __init__(self) -> None:
|
|
self.calls = 0
|
|
|
|
def execute(self) -> list[SandboxSession]:
|
|
self.calls += 1
|
|
return []
|
|
|
|
|
|
class FakeDockerClient(DockerClient):
|
|
def __init__(self) -> None:
|
|
self.close_calls = 0
|
|
|
|
def close(self) -> None:
|
|
self.close_calls += 1
|
|
|
|
|
|
def build_config() -> AppConfig:
|
|
return AppConfig(
|
|
app=AppSectionConfig(name='master', env='test'),
|
|
http=HttpConfig(host='127.0.0.1', port=8000),
|
|
logging=LoggingConfig(
|
|
level='INFO', output='stdout', format='json', file_path=None
|
|
),
|
|
metrics=MetricsConfig(enabled=False),
|
|
tracing=TracingConfig(enabled=False),
|
|
otel=OtelConfig(
|
|
service_name='master',
|
|
logs_endpoint='http://localhost:4318/v1/logs',
|
|
metrics_endpoint='http://localhost:4318/v1/metrics',
|
|
traces_endpoint='http://localhost:4318/v1/traces',
|
|
metric_export_interval=1000,
|
|
),
|
|
docker=DockerConfig(base_url='unix:///var/run/docker.sock'),
|
|
sandbox=SandboxConfig(
|
|
image='sandbox:latest',
|
|
ttl_seconds=300,
|
|
cleanup_interval_seconds=60,
|
|
chats_root='/tmp/chats',
|
|
dependencies_host_path='/tmp/dependencies',
|
|
lambda_tools_host_path='/tmp/lambda-tools',
|
|
chat_mount_path='/workspace/chat',
|
|
dependencies_mount_path='/workspace/dependencies',
|
|
lambda_tools_mount_path='/workspace/lambda-tools',
|
|
),
|
|
security=SecurityConfig(
|
|
token_header='Authorization',
|
|
api_token='token',
|
|
signing_key='signing-key',
|
|
),
|
|
)
|
|
|
|
|
|
def build_container(
|
|
config: AppConfig,
|
|
create_sandbox_usecase: FakeCreateSandboxUsecase,
|
|
cleanup_usecase: FakeCleanupExpiredSandboxes,
|
|
logger: FakeLogger,
|
|
docker_client: FakeDockerClient,
|
|
) -> AppContainer:
|
|
observability = ObservabilityRuntime(
|
|
logger=logger,
|
|
metrics=NoopMetrics(),
|
|
tracer=NoopTracer(),
|
|
)
|
|
repositories = AppRepositories(sandbox_session=InMemorySandboxSessionRepository())
|
|
usecases = AppUsecases(
|
|
create_sandbox=create_sandbox_usecase,
|
|
cleanup_expired_sandboxes=cleanup_usecase,
|
|
)
|
|
return AppContainer(
|
|
config=config,
|
|
observability=observability,
|
|
repositories=repositories,
|
|
usecases=usecases,
|
|
_docker_client=docker_client,
|
|
)
|
|
|
|
|
|
async def request_json(
|
|
app: FastAPI,
|
|
method: str,
|
|
path: str,
|
|
payload: dict[str, str] | None = None,
|
|
) -> tuple[int, dict[str, object]]:
|
|
body = b'' if payload is None else json.dumps(payload).encode()
|
|
messages: list[Message] = []
|
|
request_sent = False
|
|
|
|
async def receive() -> Message:
|
|
nonlocal request_sent
|
|
if request_sent:
|
|
await asyncio.sleep(0)
|
|
return {'type': 'http.disconnect'}
|
|
|
|
request_sent = True
|
|
return {
|
|
'type': 'http.request',
|
|
'body': body,
|
|
'more_body': False,
|
|
}
|
|
|
|
async def send(message: Message) -> None:
|
|
messages.append(message)
|
|
|
|
scope: Scope = {
|
|
'type': 'http',
|
|
'asgi': {'version': '3.0'},
|
|
'http_version': '1.1',
|
|
'method': method,
|
|
'scheme': 'http',
|
|
'path': path,
|
|
'raw_path': path.encode(),
|
|
'query_string': b'',
|
|
'root_path': '',
|
|
'headers': _build_headers(body, payload is not None),
|
|
'client': ('testclient', 50000),
|
|
'server': ('testserver', 80),
|
|
'state': {},
|
|
}
|
|
|
|
await app(scope, receive, send)
|
|
|
|
status = 500
|
|
response_body = b''
|
|
for message in messages:
|
|
if message['type'] == 'http.response.start':
|
|
status = int(message['status'])
|
|
if message['type'] == 'http.response.body':
|
|
response_body += bytes(message.get('body', b''))
|
|
|
|
if not response_body:
|
|
return status, {}
|
|
|
|
return status, json.loads(response_body.decode())
|
|
|
|
|
|
def _build_headers(body: bytes, has_json_body: bool) -> list[tuple[bytes, bytes]]:
|
|
headers = [
|
|
(b'host', b'testserver'),
|
|
(b'content-length', str(len(body)).encode()),
|
|
]
|
|
if has_json_body:
|
|
headers.append((b'content-type', b'application/json'))
|
|
return headers
|
|
|
|
|
|
async def post_json(
|
|
app: FastAPI, path: str, payload: dict[str, str]
|
|
) -> tuple[int, dict[str, object]]:
|
|
return await request_json(app, 'POST', path, payload)
|
|
|
|
|
|
async def get_json(app: FastAPI, path: str) -> tuple[int, dict[str, object]]:
|
|
return await request_json(app, 'GET', path)
|
|
|
|
|
|
async def exercise_create_request(
|
|
app: FastAPI,
|
|
payload: dict[str, str],
|
|
) -> tuple[int, dict[str, object]]:
|
|
await app.router.startup()
|
|
try:
|
|
status, response = await post_json(app, '/api/v1/create', payload)
|
|
await asyncio.sleep(0)
|
|
return status, response
|
|
finally:
|
|
await app.router.shutdown()
|
|
|
|
|
|
async def exercise_get_request(
|
|
app: FastAPI,
|
|
path: str,
|
|
) -> tuple[int, dict[str, object]]:
|
|
await app.router.startup()
|
|
try:
|
|
status, response = await get_json(app, path)
|
|
await asyncio.sleep(0)
|
|
return status, response
|
|
finally:
|
|
await app.router.shutdown()
|
|
|
|
|
|
def test_post_create_returns_session_with_canonical_chat_id(monkeypatch) -> None:
|
|
config = build_config()
|
|
expires_at = datetime(2026, 4, 2, 12, 5, tzinfo=UTC)
|
|
session = SandboxSession(
|
|
session_id='session-123',
|
|
chat_id=CHAT_ID,
|
|
container_id='container-123',
|
|
status=SandboxStatus.RUNNING,
|
|
created_at=expires_at - timedelta(minutes=5),
|
|
expires_at=expires_at,
|
|
)
|
|
logger = FakeLogger()
|
|
create_usecase = FakeCreateSandboxUsecase(session=session)
|
|
cleanup_usecase = FakeCleanupExpiredSandboxes()
|
|
docker_client = FakeDockerClient()
|
|
container = build_container(
|
|
config,
|
|
create_usecase,
|
|
cleanup_usecase,
|
|
logger,
|
|
docker_client,
|
|
)
|
|
monkeypatch.setattr(app_module, 'build_container', lambda **kwargs: container)
|
|
monkeypatch.setattr(
|
|
app_module.FastAPIInstrumentor, 'instrument_app', lambda *args, **kwargs: None
|
|
)
|
|
|
|
app = app_module.create_app(config=config)
|
|
|
|
status_code, response = asyncio.run(
|
|
exercise_create_request(app, {'chat_id': NON_CANONICAL_CHAT_ID})
|
|
)
|
|
|
|
assert status_code == 200
|
|
assert response == {
|
|
'session_id': 'session-123',
|
|
'chat_id': CHAT_ID,
|
|
'container_id': 'container-123',
|
|
'status': 'running',
|
|
'expires_at': '2026-04-02T12:05:00Z',
|
|
}
|
|
assert len(create_usecase.commands) == 1
|
|
assert create_usecase.commands[0].chat_id == CHAT_ID
|
|
assert cleanup_usecase.calls >= 1
|
|
assert any(
|
|
message == 'http_request'
|
|
and attrs is not None
|
|
and attrs['http.path'] == '/api/v1/create'
|
|
for _, message, attrs in logger.messages
|
|
)
|
|
assert docker_client.close_calls == 1
|
|
|
|
|
|
def test_post_create_rejects_non_uuid_chat_id(monkeypatch) -> None:
|
|
config = build_config()
|
|
expires_at = datetime(2026, 4, 2, 12, 5, tzinfo=UTC)
|
|
session = SandboxSession(
|
|
session_id='session-123',
|
|
chat_id=CHAT_ID,
|
|
container_id='container-123',
|
|
status=SandboxStatus.RUNNING,
|
|
created_at=expires_at - timedelta(minutes=5),
|
|
expires_at=expires_at,
|
|
)
|
|
logger = FakeLogger()
|
|
create_usecase = FakeCreateSandboxUsecase(session=session)
|
|
cleanup_usecase = FakeCleanupExpiredSandboxes()
|
|
docker_client = FakeDockerClient()
|
|
container = build_container(
|
|
config,
|
|
create_usecase,
|
|
cleanup_usecase,
|
|
logger,
|
|
docker_client,
|
|
)
|
|
monkeypatch.setattr(app_module, 'build_container', lambda **kwargs: container)
|
|
monkeypatch.setattr(
|
|
app_module.FastAPIInstrumentor, 'instrument_app', lambda *args, **kwargs: None
|
|
)
|
|
|
|
app = app_module.create_app(config=config)
|
|
|
|
status_code, response = asyncio.run(
|
|
exercise_create_request(app, {'chat_id': 'x/../y'})
|
|
)
|
|
|
|
assert status_code == 422
|
|
assert 'detail' in response
|
|
assert create_usecase.commands == []
|
|
assert docker_client.close_calls == 1
|
|
|
|
|
|
def test_post_create_maps_start_errors_to_service_unavailable(monkeypatch) -> None:
|
|
config = build_config()
|
|
logger = FakeLogger()
|
|
create_usecase = FakeCreateSandboxUsecase(error=SandboxStartError(CHAT_ID))
|
|
cleanup_usecase = FakeCleanupExpiredSandboxes()
|
|
docker_client = FakeDockerClient()
|
|
container = build_container(
|
|
config,
|
|
create_usecase,
|
|
cleanup_usecase,
|
|
logger,
|
|
docker_client,
|
|
)
|
|
monkeypatch.setattr(app_module, 'build_container', lambda **kwargs: container)
|
|
monkeypatch.setattr(
|
|
app_module.FastAPIInstrumentor, 'instrument_app', lambda *args, **kwargs: None
|
|
)
|
|
|
|
app = app_module.create_app(config=config)
|
|
|
|
status_code, response = asyncio.run(
|
|
exercise_create_request(app, {'chat_id': CHAT_ID})
|
|
)
|
|
|
|
assert status_code == 503
|
|
assert response == {'detail': 'sandbox_start_failed'}
|
|
assert docker_client.close_calls == 1
|
|
|
|
|
|
def test_post_create_maps_generic_sandbox_errors_to_internal_error(monkeypatch) -> None:
|
|
config = build_config()
|
|
logger = FakeLogger()
|
|
create_usecase = FakeCreateSandboxUsecase(error=SandboxError('sandbox_broken'))
|
|
cleanup_usecase = FakeCleanupExpiredSandboxes()
|
|
docker_client = FakeDockerClient()
|
|
container = build_container(
|
|
config,
|
|
create_usecase,
|
|
cleanup_usecase,
|
|
logger,
|
|
docker_client,
|
|
)
|
|
monkeypatch.setattr(app_module, 'build_container', lambda **kwargs: container)
|
|
monkeypatch.setattr(
|
|
app_module.FastAPIInstrumentor, 'instrument_app', lambda *args, **kwargs: None
|
|
)
|
|
|
|
app = app_module.create_app(config=config)
|
|
|
|
status_code, response = asyncio.run(
|
|
exercise_create_request(app, {'chat_id': CHAT_ID})
|
|
)
|
|
|
|
assert status_code == 500
|
|
assert response == {'detail': 'sandbox_broken'}
|
|
assert docker_client.close_calls == 1
|
|
|
|
|
|
def test_removed_user_endpoint_returns_not_found(monkeypatch) -> None:
|
|
config = build_config()
|
|
expires_at = datetime(2026, 4, 2, 12, 5, tzinfo=UTC)
|
|
session = SandboxSession(
|
|
session_id='session-123',
|
|
chat_id=CHAT_ID,
|
|
container_id='container-123',
|
|
status=SandboxStatus.RUNNING,
|
|
created_at=expires_at - timedelta(minutes=5),
|
|
expires_at=expires_at,
|
|
)
|
|
logger = FakeLogger()
|
|
create_usecase = FakeCreateSandboxUsecase(session=session)
|
|
cleanup_usecase = FakeCleanupExpiredSandboxes()
|
|
docker_client = FakeDockerClient()
|
|
container = build_container(
|
|
config,
|
|
create_usecase,
|
|
cleanup_usecase,
|
|
logger,
|
|
docker_client,
|
|
)
|
|
monkeypatch.setattr(app_module, 'build_container', lambda **kwargs: container)
|
|
monkeypatch.setattr(
|
|
app_module.FastAPIInstrumentor, 'instrument_app', lambda *args, **kwargs: None
|
|
)
|
|
|
|
app = app_module.create_app(config=config)
|
|
|
|
status_code, response = asyncio.run(
|
|
exercise_get_request(app, '/api/v1/users/user-123')
|
|
)
|
|
|
|
assert status_code == 404
|
|
assert response == {'detail': 'Not Found'}
|
|
assert docker_client.close_calls == 1
|